dweiss commented on a change in pull request #1176: LUCENE-9143 Add error-prone
checks to build, but disabled
URL: https://github.com/apache/lucene-solr/pull/1176#discussion_r367298139
##########
File path: gradle/defaults-java.gradle
##########
@@ -1,11 +1,51 @@
// Configure Java project defaults.
-allprojects {
- plugins.withType(JavaPlugin) {
+buildscript {
Review comment:
I'd prefer if you separated the configuration and application of this plugin
into a separate file (validation/errorprone.gradle)? Then each file configures
one thing. Sure - there is an overhead in multiple passes over project
collection but I think it's worth knowing what each particular file does and it
makes them shorter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
