uschindler edited a comment on issue #1172: SOLR-14189 switch from 
String.trim() to StringUtils.stripToNull()
URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-574773626
 
 
   Why not use the much more efficient StringUtils.isWhitespace() for the cases 
where the result is just checked for null? Just stripping and throwing away the 
result looks inefficient.
   
   Of course then you need null check and emptyness back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to