[
https://issues.apache.org/jira/browse/LUCENE-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015987#comment-17015987
]
Erick Erickson commented on LUCENE-9134:
----------------------------------------
I copy/pasted Mark's work for a regenerate task in
/Users/Erick/apache/solrJiras/master/lucene/queryparser/build.gradle, and I can
execute it from the top level. Is that the only place the task needs to be
defined for queryparser or are there others? I assume I'll repeat the process
for all the other regenerate tasks.
What I don't have is a good place to put Mark's script:
./buildSrc/src/main/groovy/org/apache/lucene/gradle/JavaCC.groovy which defines
the "JavaCC" task used in the build.gradle file. I'll attach it as a patch
momentarily. NOTE: I haven't checked it at all for correctness. My goal is to
get the structure in place, then reconcile/tweak before pushing, then move on
to the next one. Or is this even the right approach?
Thanks!
> Port ant-regenerate tasks to Gradle build
> -----------------------------------------
>
> Key: LUCENE-9134
> URL: https://issues.apache.org/jira/browse/LUCENE-9134
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> Here are the "regenerate" targets I found in the ant version. There are a
> couple that I don't have evidence for or against being rebuilt
> // Very top level
> {code:java}
> ./build.xml: <target name="regenerate" description="Runs all code
> regenerators">
> ./build.xml: <subant target="regenerate" inheritall="false"
> failonerror="true">
> ./build.xml: <target name="regenerateAndCheck"
> depends="regenerate,-check-after-regeneration"/>
> {code}
> // top level Lucene. This includes the core/build.xml and
> test-framework/build.xml files
> {code:java}
> ./lucene/build.xml: <target name="regenerate">
> ./lucene/build.xml: <subant target="regenerate" failonerror="true"
> inheritall="false">
> ./lucene/build.xml: <modules-crawl target="regenerate"/>
> {code}
> // This one has quite a number of customizations to
> {code:java}
> ./lucene/core/build.xml: <target name="regenerate"
> depends="createLevAutomata,createPackedIntSources,jflex"/>
> {code}
> // This one has a bunch of code modifications _after_ javacc is run on
> certain of the
> // output files. Save this one for last?
> {code:java}
> ./lucene/queryparser/build.xml: <target name="regenerate" depends="javacc"/>
> {code}
> // the files under ../lucene/analysis... are pretty self contained. I expect
> these could be done as a unit
> {code:java}
> ./lucene/analysis/build.xml: <target name="regenerate">
> ./lucene/analysis/build.xml: <forall-analyzers target="regenerate"/>
> ./lucene/analysis/common/build.xml: <target name="regenerate"
> depends="jflex,unicode-data"/>
> ./lucene/analysis/icu/build.xml: <target name="regenerate"
> depends="gen-utr30-data-files,gennorm2,genrbbi"/>
> ./lucene/analysis/kuromoji/build.xml: <target name="regenerate"
> depends="build-dict"/>
> ./lucene/analysis/nori/build.xml: <target name="regenerate"
> depends="build-dict"/>
> ./lucene/analysis/opennlp/build.xml: <target name="regenerate"
> depends="train-test-models"/>
> {code}
>
> // These _are_ regenerated from the top-level regenerate target, but for --
> LUCENE-9080//the changes were only in imports so there are no
> //corresponding files checked in in that JIRA
> {code:java}
> ./lucene/expressions/build.xml: <target name="regenerate"
> depends="run-antlr"/>
> {code}
> // Apparently unrelated to ./lucene/analysis/opennlp/build.xml
> "train-test-models" target
> // Apparently not rebuilt from the top level, but _are_ regenerated when
> executed from
> // ./solr/contrib/langid
> {code:java}
> ./solr/contrib/langid/build.xml: <target name="regenerate"
> depends="train-test-models"/>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
