[
https://issues.apache.org/jira/browse/SOLR-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014410#comment-17014410
]
Jason Gerlowski commented on SOLR-14186:
----------------------------------------
I've linked PR #1162 which only changes the line endings back to CRLF. I
didn't want to hold that fix up while I give people time to review a
gitattributes file (coming in a subsequent PR).
I'm going to merge #1162 as soon as precommit passes and then move onto the
gitattribute change itself.
> Ensure Windows files retain CRLF endings
> ----------------------------------------
>
> Key: SOLR-14186
> URL: https://issues.apache.org/jira/browse/SOLR-14186
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
> Affects Versions: master (9.0), 8.4
> Reporter: Jason Gerlowski
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We've had several recent instances where our Windows files (solr.cmd,
> solr.in.cmd) end up getting their Windows-specific line-endings stripped out.
> This causes chunks of those scripts to fail when run on Windows.
> e.g. SOLR-13977 fixed an issue where {{bin\solr.cmd create -c}} failed, and
> the problem was fixed and recurred again within a week.
> Generally, contributors/committers can prevent this by setting their
> {{core.autocrlf}} git setting to {{input}}. But we should also put
> repository-wide settings in place exempting certain files from line-ending
> conversion entirely.
> This issue proposes adding a .gitattributes setting to special-case
> OS-specific files (bash scripts, Windows batch files, etc.) This will
> prevent solr.cmd's line endings from being changed by committers who forget
> to configure the setting on a new machine, etc.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
