[
https://issues.apache.org/jira/browse/SOLR-13934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013214#comment-17013214
]
Jason Gerlowski commented on SOLR-13934:
----------------------------------------
I made a few tweaks visible on the PR: particularly I combined the
SimplePostTool and "Windows Support" sections, which had some duplication. I
also changed to asciidoc formatting to have 1 sentence per line, which allows
subsequent changes to show up a bit nicer in diffs.
bq. Related maybe, should a lot of the code in the shell script be moved into
the post.jar?
I agree. If we keep the bin/post tool around longer term (or someone gets a
chance now), that logic should all move into the jar. There's no reason to
duplicate it. The {{bin/solr}} and {{bin/solr.cmd}} scripts could benefit from
this in much the same way, coincidentally. It's been on my backburner for a
long time. (It's an easy change but a hard one to verify, since there's no
tests to check bin/solr behavior with).
I'll merge the doc changes soon. If anyone has suggestions (before or after)
let me know.
> Documentation on SimplePostTool for Windows users is pretty brief
> -----------------------------------------------------------------
>
> Key: SOLR-13934
> URL: https://issues.apache.org/jira/browse/SOLR-13934
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SimplePostTool
> Affects Versions: 8.3
> Reporter: David Eric Pugh
> Assignee: Jason Gerlowski
> Priority: Minor
> Fix For: master (9.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SimplePostTool on windows doesn't have enough documentation, you end up
> googling to get it to work. Need to provide better example.
> https://lucene.apache.org/solr/guide/8_3/post-tool.html#simpleposttool
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
