shbhar commented on PR #16923: URL: https://github.com/apache/lucene/pull/16923#issuecomment-6703349221
Thanks again for the fixes here, and for #16996, #17003 and #17006! It will take me some time, but I will spend time reviewing them next week. In case you're interested in more bugs in this area and wish to knock them all out, the findings list has quite a few related ones (each with a minimal failing test and a write-ups with many more details): | Area | Link | |---|---| | Soft deletes | [?q=soft](https://shbhar.github.io/lucene-ai-bug-hunt/?q=soft#bugs) | | Doc-values updates | [?q=doc-values update](https://shbhar.github.io/lucene-ai-bug-hunt/?q=doc-values%20update#bugs) | | NRT readers | [?q=nrt](https://shbhar.github.io/lucene-ai-bug-hunt/?q=nrt#bugs) | Adding `&known=1` also shows the ones that were already known upstream (for example [soft deletes incl. known](https://shbhar.github.io/lucene-ai-bug-hunt/?q=soft&known=1#bugs)), and `&priority=medium` narrows to the Medium ones. Your three new PRs fix [LFV-008](https://shbhar.github.io/lucene-ai-bug-hunt/bugs/LFV-008.html#bugs) (#17003), [LFV-460](https://shbhar.github.io/lucene-ai-bug-hunt/bugs/LFV-460.html#bugs) (#17006, item 4) and LFV-593 (#16996) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
