uschindler commented on code in PR #16931:
URL: https://github.com/apache/lucene/pull/16931#discussion_r4410597664
##########
lucene/core/src/java/org/apache/lucene/store/RefCountedSharedArena.java:
##########
@@ -140,6 +138,19 @@ public MemorySegment.Scope scope() {
return arena.scope();
}
+ // equals and hashCode are intentionally identity based and final:
MMapDirectory's
+ // arenas.remove(key, arena) relies on that.
+
+ @Override
+ public boolean equals(Object obj) {
Review Comment:
ah class is final, maber still mark it final here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
