diwu-sf commented on issue #16900: URL: https://github.com/apache/lucene/issues/16900#issuecomment-6478056957
When you fix this, since the fix is to the NRT reader, can you also make sure to cover an adjacent bug: > A reader opened during a commit. A commit bumps the version first, then syncs files to disk, and only then switches to the new segments_N file. A reader opened during the sync gets the new version but still points at the old segments_N. Because the versions match, it is treated as up to date even after that file is deleted. Fix: also check that the reader points at the latest commit. If you look at the PR https://github.com/apache/lucene/pull/16923 it will have the fix + failing test cases. This is the root cause of the upstream OpenSearch bug https://github.com/opensearch-project/OpenSearch/issues/11025 I would prefer for this to be fixed in Lucene vs having to patch around it in OpenSearch. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
