gerlowskija opened a new pull request #1159: SOLR-13892: Add top-level docValues "join" implementation URL: https://github.com/apache/lucene-solr/pull/1159 # Description Many "join" use-cases can be made more performant by using "top-level" docValues data structures, instead of the per-segment structures that are used currently. Users should have the ability to pick between top-level and per-segment, based on the particulars of their index and use case. # Solution This PR introduces a "top-level" implementation in the form of a "join" postfilter. Users get the "top-level" behavior by specifying `cache=false cost=101` as local params on their join. We may decide to repackage this implementation as a Two-Phase Iterator before merging, though that is still up in the air. # Tests Functional tests have been added in TestJoin.java. Performance tests validating the improvement performance in select use-cases can be found in the comments on SOLR-13892. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `master` branch. - [X] I have run `ant precommit` and the appropriate test suite. - [X] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
