thecoop commented on code in PR #16905:
URL: https://github.com/apache/lucene/pull/16905#discussion_r4376483259
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java:
##########
@@ -75,8 +78,8 @@ public final class Lucene99FlatVectorsReader extends
FlatVectorsReader {
private final String vectorDataFN;
// the reader this one was created from
private final Lucene99FlatVectorsReader original;
- // the input for sequential reads, opened lazily and closed with this reader
- private IndexInput sequentialVectorData;
+ // the inputs for other contexts, closed with this reader, guarded by this
+ private final Map<IOContext, IndexInput> otherVectorData = new HashMap<>();
Review Comment:
Keying on `IOContext` is not a good idea, it doesn't have any identity
semantics. Maybe on `IOContext.Context`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
