mbwaheed commented on a change in pull request #1131: SOLR-14134: Add lazy and
time-based evictiction of shared core concurrency metada…
URL: https://github.com/apache/lucene-solr/pull/1131#discussion_r364513879
##########
File path:
solr/core/src/java/org/apache/solr/store/shared/SharedCoreConcurrencyController.java
##########
@@ -129,18 +130,29 @@
* If it does then either we are too slow in pulling and can tune this value
or something else is wrong.
*/
public static int MAX_ATTEMPTS_INDEXING_PULL_WRITE_LOCK = 10;
+
+ /**
+ * Maximum number of SharedCoreVersionMetadata to keep in an in-memory cache
before we start
+ * evicting entries
+ */
+ public static int MAX_CACHE_SIZE = 5000;
+
+ /**
+ * Time in seconds that needs to pass before evicting entries from the
in-memory cache that haven't
+ * accessed recently
+ */
+ public static int CACHE_EXPIRATION_TIME_SECONDS = 60*60*12;
Review comment:
This can be deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
