dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-571936438 > Are we buffering output in both PrefixWriter and SpillWriter? Why do we need to do that in two places? To distinguish between syserr and sysout; they are flushed independently if they're mixed (with a different line prefix). This helps to distinguish what was emitted from where. So you'd get consistent output even if you used print() (without a flush). ``` 1> sysout print 2> syserr print ``` Arguably this could be simplified to just use a single stream but found it really useful to distinguish between syserr and sysout in many debugging sessions... bq. No special handling for the reproduce with line? One thing at a time. Reproduce line has to work for both ant and gradle. Also - Gradle failed test summary could display a much better (shorter) version of the reproduce line. It knows which properties have been changed from their default values and what the test seed was. It only needs to display something like: ``` Reproduce with: ./gradlew -p [project] test --tests [testcase] [non-default properties] ``` the internal reproduce line is still useful as a "verbose" information about which properties were used but I think this can be an additional thing to the above. I'll work on it later today (since I know where all the bits and pieces are). This said, I appreciate you getting familiar with all of this infrastructure, Mike. Please keep doing this!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
