[
https://issues.apache.org/jira/browse/SOLR-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009202#comment-17009202
]
ASF subversion and git services commented on SOLR-13932:
--------------------------------------------------------
Commit 7d728d9d3a552dda75272bf339f17cae9d6b3734 in lucene-solr's branch
refs/heads/jira/SOLR-13101 from murblanc
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7d728d9 ]
SOLR-13932 Review directory locking and Blob interactions (#1055)
* Initial minor changes for SOLR-13932
* Use all files in index directory when doing resolution against Blob to switch
local index to new dir in case of conflicts
* Do push from the index directory directly without first making a local copy
of the index files
* misspelling
* update after comments from mbwaheed
> Review directory locking and Blob interactions
> ----------------------------------------------
>
> Key: SOLR-13932
> URL: https://issues.apache.org/jira/browse/SOLR-13932
> Project: Solr
> Issue Type: Sub-task
> Reporter: Ilan Ginzburg
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Review resolution of local index directory content vs Blob copy.
> There has been wrong understanding of following line acquiring a lock on
> index directory.
> {{solrCore.getDirectoryFactory().get(indexDirPath,
> DirectoryFactory.DirContext.DEFAULT,
> solrCore.getSolrConfig().indexConfig.lockType);}}
> From Yonik:
> _A couple things about Directory locking.... the locks were only ever to
> prevent more than one IndexWriter from trying to modify the same index. The
> IndexWriter grabs a write lock once when it is created and does not release
> it until it is closed._
> _Directories are not locked on acquisition of the Directory from the
> DirectoryFactory. See the IndexWriter constructor, where the lock is
> explicitly grabbed._
> Review CorePushPull#pullUpdateFromBlob, ServerSideMetadata and other classes
> as relevant.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
