[
https://issues.apache.org/jira/browse/LUCENE-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009012#comment-17009012
]
Erick Erickson commented on LUCENE-9080:
----------------------------------------
I think I have it working. Current state:
* regenerate works
* precommit passes
* full test suite passes
* I updated to ICU 64.2, see above.
* I ran an absolutely minimal test of Solr, just "bin/solr start -e
techproducts" and did a search.
The fact that some of the binary files got regenerated makes me a little
nervous, but all tests pass and I can fire up Solr.
[~jpountz] : I'm flying a little blind here, WDYT about the changes to
util/packed? I pulled out what I hope are the correct bits from the Packed
directory, and changed the build file: see the changes in
lucene/core/build.xml. I deleted gen_PackedThreeBlocks.py and gen_Direct.py as
well. I'm trusting that the tests would barf if they were necessary. As a test
I deleted everything in util/packed that had the "DO NOT EDIT" tag before I
regenerated to see if anything broke. Since files like BulkOperation*.java
regenerated I feel more confident.
The files I manually changed were:
lucene/core/build.xml
utils/packed/gen_Packed64SingleBlock.py
gen_Direct.py (deleted)
gen_PackedThreeBlocks.py (deleted)
generateUTR30DataFiles.java
ivy-versions.properties
The rest of the changes are a result of running the regenerate.
I'll push it to master in the next day or so absent objections.
[~dawid.weiss] [~jpountz] [~rcmuir] [~mikemccand] [~uschindler] et.al. what do
you think about merging this back to 8x? Nobody's apparently run regenerate in
ages, and my motivation is to have a working baseline for the Gradle build
which won't be 8x anyway. Maybe raise another Jira that points back here if for
posterity in case someone else needs to do this?
Oh, and I'm finally trying to get all modern and use PRs, pardon me if I screw
it up.
> Upgrade ICU4j to 62.2 and regenerate
> ------------------------------------
>
> Key: LUCENE-9080
> URL: https://issues.apache.org/jira/browse/LUCENE-9080
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: after_regen.patch, before_regen.patch, status.res
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The root cause is that RamUsageEstimator.NUM_BYTES_INT has been removed and
> the python scripts still reference it in the generated scripts. That part's
> easy to fix.
> Last time I looked, though, the regenerate produces some differences in the
> generated files that should be looked at to insure they're benign.
> Not really sure whether this should be a Lucene or Solr JIRA. Putting it in
> Lucene since one of the failed files is:
> lucene/core/src/java/org/apache/lucene/util/packed/Packed8ThreeBlocks.java
> I do know that one of the Solr jflex-produced file has an unexplained
> difference so it may bleed over.
> "ant regenerate" needs about 24G on my machine FWIW.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
