[ 
https://issues.apache.org/jira/browse/SOLR-14164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008491#comment-17008491
 ] 

David Smiley commented on SOLR-14164:
-------------------------------------

Marking SOLR-14166 as "required" for the issue here because I think it's 
necessary that TwoPhaseIterator be used more optimally before we change a query 
that has PostFilter to then use TPI.

> Replace Solr's FunctionRangeQuery with Lucene's
> -----------------------------------------------
>
>                 Key: SOLR-14164
>                 URL: https://issues.apache.org/jira/browse/SOLR-14164
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Solr has a FunctionRangeQuery. It is constant scoring and also a post-filter. 
>  Lucene has a FunctionRangeQuery that I added years ago LUCENE-6919.  It is 
> not constant scoring as it scores based on the wrapped ValueSource, although 
> this is easily made the same as Solr's by wrapping in a ConstantScoreQuery.  
> And it uses Lucene's TwoPhaseIterator indirectly which is equivalent 
> functionality to Solr's PostFilter.  Consequently we can remove Solr's 
> implementation.  Additionally, ValueSourceRangeFilter is a piece of the 
> puzzle that can be removed as Solr's FunctionQuery was a wrapper around this 
> specifically.  FYI Once upon a time, Query and Filter were separate, then 
> Filter was made to subclass Query and then Filter was relegated to Solr as 
> tech debt.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to