murblanc commented on a change in pull request #1055: SOLR-13932 Review
directory locking and Blob interactions
URL: https://github.com/apache/lucene-solr/pull/1055#discussion_r362514824
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/metadata/CorePushPull.java
##########
@@ -268,7 +264,7 @@ public void pullUpdateFromBlob(long requestQueuedTimeMs,
boolean waitForSearcher
}
Review comment:
Pull is indeed exclusive, but let's not rely on this (i.e. be defensive). We
do check the directory hasn't changed during the pull before adding back the
files and reopening the IW, so I think we're ok.
Not sure about your reference @mbwaheed to SolrIndexSplitter. The lock is
acquired there on a directory that I'm not sure is the index directory (it is
searcher.getRawReader().directory() on the passed instance of
SolrIndexSearcher). We manipulate solrCore.getIndexDir().
The directory and IndexWriter manipulation in
IndexFetcher.fetchLatestIndex() is similar to the one we do here (no surprise,
it was used as "inspiration").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
