[
https://issues.apache.org/jira/browse/LUCENE-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006851#comment-17006851
]
Ignacio Vera commented on LUCENE-8673:
--------------------------------------
I don't think it is an issue with the code, the test is running with RAM
directory and therefore OOM is possible when. using the offline writer:
{code:java}
java.lang.OutOfMemoryError: Java heap space
at
__randomizedtesting.SeedInfo.seed([34794AE69CB7F902:B32E37690DEE8582]:0)
at org.apache.lucene.store.RAMFile.newBuffer(RAMFile.java:84)
at org.apache.lucene.store.RAMFile.addBuffer(RAMFile.java:57)
at
org.apache.lucene.store.RAMOutputStream.switchCurrentBuffer(RAMOutputStream.java:168)
at
org.apache.lucene.store.RAMOutputStream.writeBytes(RAMOutputStream.java:154)
at
org.apache.lucene.store.MockIndexOutputWrapper.writeBytes(MockIndexOutputWrapper.java:141)
at
org.apache.lucene.util.bkd.OfflinePointWriter.append(OfflinePointWriter.java:67)
at
org.apache.lucene.util.bkd.BKDRadixSelector.offlinePartition(BKDRadixSelector.java:282)
{code}
I do not remember how to disable that type of directory in tyre test but we
should prevent it.
> Use radix partitioning when merging dimensional points
> ------------------------------------------------------
>
> Key: LUCENE-8673
> URL: https://issues.apache.org/jira/browse/LUCENE-8673
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ignacio Vera
> Assignee: Ignacio Vera
> Priority: Major
> Fix For: 8.x, master (9.0)
>
> Attachments: Geo3D.png, Geo3D.png, Geo3D.png, LatLonPoint.png,
> LatLonPoint.png, LatLonPoint.png, LatLonShape.png, LatLonShape.png,
> LatLonShape.png
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Following the advise of [~jpountz] in LUCENE-8623I have investigated using
> radix selection when merging segments instead of sorting the data at the
> beginning. The results are pretty promising when running Lucene geo
> benchmarks:
>
> ||Approach||Index time (sec): Dev||Index Time (sec): Base||Index Time:
> Diff||Force merge time (sec): Dev||Force Merge time (sec): Base||Force Merge
> Time: Diff||Index size (GB): Dev||Index size (GB): Base||Index Size:
> Diff||Reader heap (MB): Dev||Reader heap (MB): Base||Reader heap: Diff
> |points|241.5s|235.0s| 3%|157.2s|157.9s|-0%|0.55|0.55| 0%|1.57|1.57| 0%|
> |shapes|416.1s|650.1s|-36%|306.1s|603.2s|-49%|1.29|1.29| 0%|1.61|1.61| 0%|
> |geo3d|261.0s|360.1s|-28%|170.2s|279.9s|-39%|0.75|0.75| 0%|1.58|1.58| 0%|
>
> edited: table formatting to be a jira table
>
> In 2D the index throughput is more or less equal but for higher dimensions
> the impact is quite big. In all cases the merging process requires much less
> disk space, I am attaching plots showing the different behaviour and I am
> opening a pull request.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
