dsmiley commented on issue #1124: SOLR-14151 :Schema components to be loadable from packages URL: https://github.com/apache/lucene-solr/pull/1124#issuecomment-569594631 I appreciate that your perspective is that I am engaging in "bike shedding" -- debating matters of little substance. From my perspective, I am concerned with complexity, and thus the _how_ matters. I've realized a long time ago that writing code that works (notwithstanding unforeseen bugs) is only part of what matters and doesn't count for much. What also matters is lots of quality "ilities" -- complexity (/ simplicity), extensibility, readability, efficiency, and various others. All are somewhat subjective characteristics that differentiate one working solution from another. The solutions developed by the 'n' developers in your example are not equivalent just because they all work. These quality characteristics impact the future of the project and all of us maintaining it going forward. I fear the complexity impact in this PR. A new abstraction that will be used widely that competes with an existing one isn't my biggest concern but it's one I thought I could articulate well (though it seems I'm doing poorly). My biggest complexity concern is the impact of supporting hot-loading. Hot-loading is a cool feature to tell users about but the complexity implications of the implementation scare me, and more so here at the schema. It's not just some feature that stays on the sidelines if not used (e.g. some misc query parser); this affects our foundation. By "scare me"; it's like what you were saying earlier about code we are scared to touch because we don't understand it (due to complexity of course). I confess; some of my fear is mere ignorance of what I know little about. You could help with that. Perhaps help explain how schema hot reloading works. And then ultimately put that in javadoc somewhere. Frankly this patch is getting too complex for me to see for myself; I've never actually gotten through the whole thing. I can't see the forest for the trees. -0 to commit as is. I can understand you want to commit any way; you seem abundantly confident in everything you've done.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
