dsmiley commented on a change in pull request #1106: LUCENE-9106: UniformSplit
postings format allows extension of block/line serializers.
URL: https://github.com/apache/lucene-solr/pull/1106#discussion_r361070689
##########
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/uniformsplit/UniformSplitTermsReader.java
##########
@@ -68,16 +68,18 @@
* It can be used for decompression or decryption.
*/
public UniformSplitTermsReader(PostingsReaderBase postingsReader,
SegmentReadState state, BlockDecoder blockDecoder) throws IOException {
- this(postingsReader, state, blockDecoder, NAME, VERSION_START,
VERSION_CURRENT,
+ this(postingsReader, state, blockDecoder, new FieldMetadata.Serializer(),
NAME, VERSION_START, VERSION_CURRENT,
Review comment:
Since it appears the default instance has no state, can't we re-use a shared
static instance of this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
