bruno-roustant commented on a change in pull request #1113: SOLR-14131: adds 
maxQueryLength option
URL: https://github.com/apache/lucene-solr/pull/1113#discussion_r360949198
 
 

 ##########
 File path: 
solr/core/src/test/org/apache/solr/spelling/DirectSolrSpellCheckerTest.java
 ##########
 @@ -88,6 +88,45 @@ public void testOnlyMorePopularWithExtendedResults() throws 
Exception {
         
"//lst[@name='spellcheck']/lst[@name='suggestions']/lst[@name='fox']/arr[@name='suggestion']/lst/int[@name='freq']=2",
         "//lst[@name='spellcheck']/bool[@name='correctlySpelled']='true'"
     );
-  }  
+  }
+
+  @Test
+  public void testMaxQueryLength() throws Exception {
+    testMaxQueryLength(true);
+    testMaxQueryLength(false);
+  }
+
+  private void testMaxQueryLength(Boolean limitQueryLength) throws Exception {
+
+    DirectSolrSpellChecker checker = new DirectSolrSpellChecker();
+    NamedList spellchecker = new NamedList();
 
 Review comment:
   We should use generics here: NamedList<Object> spellchecker = new 
NamedList<>();

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to