[ 
https://issues.apache.org/jira/browse/SOLR-14125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002040#comment-17002040
 ] 

Joel Bernstein edited comment on SOLR-14125 at 12/23/19 1:32 AM:
-----------------------------------------------------------------

If I'm understanding the package loader correctly it will take a core reload to 
load the new functions. 

It's probably a good idea just to review the lifecycle of the StreamHandler and 
see if it all works properly following a reload. Also a good idea to refresh my 
understanding of how *inform* is called, now that hotloading exists. Don't 
worry about any of this for this ticket, I'll test this all out and harden 
things if need be before the next release.

So, as long as all the existing test cases are passing I think this looks ready 
to go.


was (Author: joel.bernstein):
If I'm understanding the package loader correctly it will take a core reload to 
load the new functions.

It's probably a good idea just to review the lifecycle of the StreamHandler and 
see if it all works properly following a reload. Also a good idea to refresh my 
understanding of how *inform* is called, now that hotloading exists. I'll test 
this all out and harden things if need be before the next release.

So, as long as all the existing test cases are passing I think this looks ready 
to go.

> <expressible> plugins must be hot loadable
> ------------------------------------------
>
>                 Key: SOLR-14125
>                 URL: https://issues.apache.org/jira/browse/SOLR-14125
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Priority: Major
>              Labels: packagemanager
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Today, the class is loaded at the core load time an a stong reference is 
> held. Package loading need it to be lazily loaded



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to