shalinmangar commented on a change in pull request #1100: SOLR-13579: Create
resource management API
URL: https://github.com/apache/lucene-solr/pull/1100#discussion_r359712223
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -1012,6 +1045,10 @@ public void shutdown() {
}
}
+ if (resourceManager != null) {
Review comment:
Nit: the null check is redundant, closeQuietly will null check anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
