[ 
https://issues.apache.org/jira/browse/SOLR-14042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Gerlowski updated SOLR-14042:
-----------------------------------
    Fix Version/s: 8.5
                   master (9.0)
       Resolution: Fixed
           Status: Resolved  (was: Patch Available)

> Fix 7 Varargs methods should only override or be overridden by other varargs 
> methods warnings
> ---------------------------------------------------------------------------------------------
>
>                 Key: SOLR-14042
>                 URL: https://issues.apache.org/jira/browse/SOLR-14042
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Andras Salamon
>            Assignee: Jason Gerlowski
>            Priority: Minor
>             Fix For: master (9.0), 8.5
>
>         Attachments: SOLR-14042-01.patch
>
>
> Precommit lists 7 quite similar varargs related warnings:
> {noformat}
> [ecj-lint] 1. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/ConcatEvaluator.java
>  (at line 46)
>  [ecj-lint]     public Object doWork(Object values[]) throws IOException {
>  [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Varargs methods should only override or be overridden by other 
> varargs methods unlike ConcatEvaluator.doWork(Object[]) and 
> ManyValueWorker.doWork(Object...)
> --
>  [ecj-lint] 2. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DateEvaluator.java
>  (at line 44)
>  [ecj-lint]     public Object doWork(Object values[]) throws IOException {
>  [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Varargs methods should only override or be overridden by other 
> varargs methods unlike DateEvaluator.doWork(Object[]) and 
> ManyValueWorker.doWork(Object...)
> --
>  [ecj-lint] 3. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DbscanEvaluator.java
>  (at line 44)
>  [ecj-lint]     public Object doWork(Object values[]) throws IOException {
>  [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Varargs methods should only override or be overridden by other 
> varargs methods unlike DbscanEvaluator.doWork(Object[]) and 
> ManyValueWorker.doWork(Object...)
> --
>  [ecj-lint] 4. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/EmpiricalDistributionEvaluator.java
>  (at line 41)
>  [ecj-lint]     public Object doWork(Object[] values) throws IOException {
>  [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Varargs methods should only override or be overridden by other 
> varargs methods unlike EmpiricalDistributionEvaluator.doWork(Object[]) and 
> ManyValueWorker.doWork(Object...)
> --
>  [ecj-lint] 5. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java
>  (at line 39)
>  [ecj-lint]     public Object doWork(Object[] values) throws IOException {
>  [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Varargs methods should only override or be overridden by other 
> varargs methods unlike MatchesEvaluator.doWork(Object[]) and 
> ManyValueWorker.doWork(Object...)
> --
>  [ecj-lint] 6. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/MatchesEvaluator.java
>  (at line 39)
>  [ecj-lint]     public Object doWork(Object[] values) throws IOException {
>  [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Varargs methods should only override or be overridden by other 
> varargs methods unlike MatchesEvaluator.doWork(Object[]) and 
> RecursiveBooleanEvaluator.doWork(Object...)
> --
>  [ecj-lint] 7. WARNING in 
> /Users/andrassalamon/src/lucene-solr-upstream/solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/PivotEvaluator.java
>  (at line 45)
>  [ecj-lint]     public Object doWork(Object[] values) throws IOException {
>  [ecj-lint]                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  [ecj-lint] Varargs methods should only override or be overridden by other 
> varargs methods unlike PivotEvaluator.doWork(Object[]) and 
> ManyValueWorker.doWork(Object...) {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to