[ 
https://issues.apache.org/jira/browse/SOLR-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998929#comment-16998929
 ] 

Dawid Weiss commented on SOLR-14099:
------------------------------------

[~hossman] Chris - shouldn't this be moved into BeforeClass block?
{code}
+  /** 
+   * We don't want a hardocded assumption here because it may change based on 
how the user runs the test.
+   */
+  public static final Level DEFAULT_LOG_LEVEL = 
LogManager.getRootLogger().getLevel();
{code}
A static class initializer will be invoked once (per JVM) whereas a BeforeClass 
block runs before each test class (even if it's in a shared superclass).

Don't know what the intention is here but my gut feeling is that this should be 
moved inside the initialization block.



> @LogLevel annotation not properly reseting after end of test (causes 
> LoggingHandlerTest.testLogLevelHandlerOutput failures)
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-14099
>                 URL: https://issues.apache.org/jira/browse/SOLR-14099
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>             Fix For: master (9.0), 8.5
>
>         Attachments: SOLR-14099.patch, SOLR-14099.patch, 
> SOLR-14099_test_workaround.patch
>
>
> We've seen a recent uptick in jenkins failures from 
> {{LoggingHandlerTest.testLogLevelHandlerOutput}} that indicate the @LogLevel 
> usage in other tests that have run earlier in the same JVM are _NOT_ properly 
> being reset when those tests complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to