yonik commented on a change in pull request #1055: SOLR-13932 Review directory
locking and Blob interactions
URL: https://github.com/apache/lucene-solr/pull/1055#discussion_r359076109
##########
File path:
solr/core/src/java/org/apache/solr/store/blob/metadata/CorePushPull.java
##########
@@ -268,7 +264,7 @@ public void pullUpdateFromBlob(long requestQueuedTimeMs,
boolean waitForSearcher
}
Review comment:
In general, Solr does not rely on the low level lucene IndexWriter lock.
It's really just an additional safety mechanism, and a failure to aquire the
lock really means that something else went badly wrong (a bug, or an external
process.) The one true IndexWriter (and changes to it) are generally controlled
by the SolrCoreState class.
The comments around pull being an exclusive operation sound correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
