sigram commented on a change in pull request #1071: SOLR-14003: Refactor code to avoid reading state from Replica/Slic URL: https://github.com/apache/lucene-solr/pull/1071#discussion_r358176763
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/DirectShardState.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.client.solrj.cloud; + +import java.util.function.Predicate; + +import org.apache.solr.common.cloud.Replica; +import org.apache.solr.common.cloud.Slice; + +/**Reads the state from state.json + * + */ +public class DirectShardState implements ShardStateProvider { Review comment: I think we have to decide where we keep (and maintain) the actual state. The API that you proposed provides two ways of getting this info, and two potential locations to get it (which may get out of sync, or have different staleness), which in my opinion is one too many :) If the replica state resides in `Replica` and this is our source of truth then having a `ShardStateProvider` seems pointless. What is the source of truth then - the state that is cached in `Replica` or the state that we obtain from `ShardStateProvider` implementation, which is guaranteed to the the most up-to-date? My understanding was that the purpose of introducing `ShardStateProvider` was to provide The single API point that is the only source of truth about the current shard/replica state (similar to other *StateProvider-s). In this model `Replica` becomes a simple static descriptor and it's NOT responsible for caching its state - that's the role of `ShardStateProvider`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
