chatman commented on a change in pull request #1083: SOLR-13662: Fixes to
package manager
URL: https://github.com/apache/lucene-solr/pull/1083#discussion_r357953736
##########
File path:
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java
##########
@@ -220,12 +239,21 @@ private boolean deployPackage(SolrPackageInstance
packageInstance, boolean pegTo
}
}
- // Verify that package was successfully deployed
- boolean success = verify(packageInstance, collections);
- if (success) {
- PackageUtils.printGreen("Deployed and verified package: " +
packageInstance.name + ", version: " + packageInstance.version);
+ List<String> deployedCollections = new ArrayList<String>();
+ for (String c: collections) if (alreadyDeployed.contains(c) == false)
deployedCollections.add(c);
Review comment:
Used the stream() / filter() / collection() here. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
