rmuir commented on a change in pull request #1082: SOLR-13984: add (experimental, disabled by default) security manager support URL: https://github.com/apache/lucene-solr/pull/1082#discussion_r357936373
########## File path: solr/bin/solr.cmd ########## @@ -994,7 +994,7 @@ set "EXAMPLE_DIR=%SOLR_TIP%\example" set TMP_SOLR_HOME=!SOLR_HOME:%EXAMPLE_DIR%=! IF NOT "%TMP_SOLR_HOME%"=="%SOLR_HOME%" ( set "SOLR_LOGS_DIR=%SOLR_HOME%\..\logs" - set "LOG4J_CONFIG=file:///%SOLR_SERVER_DIR%\resources\log4j2.xml" + set "LOG4J_CONFIG=%SOLR_SERVER_DIR%\resources\log4j2.xml" Review comment: You can't make URLs of things unless you encode them, if there are spaces in `SOLR_SERVER_DIR` this is all messed up. So i fixed it to use a standard path instead: https://logging.apache.org/log4j/log4j-2.1/faq.html#config_location Looks like the same bug exists in `bin/solr` too, i'll make a space on os X and try it out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
