[
https://issues.apache.org/jira/browse/SOLR-14080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995789#comment-16995789
]
Chris M. Hostetter commented on SOLR-14080:
-------------------------------------------
I should point out, in an ideal world ever subclass of
BaseDistributedSearchTestCase should be ported over to a SolrCLoudTestCase, but
at least BaseDistributedSearchTestCase is a little simpler in what it does –
and re-writting all of those tests (that heavily depend on comparing the
control collection with the "sharded" collection) will likely require a lot
more work to "get right".
BaseDistributedSearchTestCase also aren't quite as finicky as the
AbstractDistribZkTestBase tests because of how much simpler the overall
plumbing is ... in particular, i found this note in my "TODO" list from a while
back...
{noformat}
TODO: AbstractFullDistribZkTestBase is a fucking abomination that needs to die.
TODO: the way it creates collections causes every replica to be in recovery
from the moment it's created.
TODO: in general all tests using this base class should just be re-written from
scratch using MiniSolrCloud
{noformat}
...i don't even remember what exactly this was refering to, but I trust myself
that it's true (at least for whatever convoluted default way
AbstractFullDistribZkTestBase has for creating collections)
> Replace all legacy Abstract(Full)DistribZkTestBase tests with
> SolrCloudTestCase equivilents
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-14080
> URL: https://issues.apache.org/jira/browse/SOLR-14080
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Priority: Major
>
> AbstractDistribZkTestBase and in particular AbstractFullDistribZkTestBase are
> antiquated - and really just plan terrible and convoluted - "plumbing" for
> writing distributed tests, that "sort of kind of" emulate SolrCloud, but also
> have a lot of other crap & cruft in them that can be
> abused/missused/missunderstood. Any tests using them should be re-written to
> subclass SolrCloudTestCase
> This issue should serve as a tracking point for linking other issues and/or
> sub-tasks targeting individual test classes and/or refactoring common
> functionality to make tests easy to port.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
