[ 
https://issues.apache.org/jira/browse/SOLR-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994163#comment-16994163
 ] 

Robert Muir commented on SOLR-14061:
------------------------------------

If i had to make a simple guess, I would say problem likely relates to the call 
to {{exists}} that hits SecurityException. Its going to be inherently a race 
condition by default from the filesystem perspective, it should really be a 
forbidden api. But then it throws unexpected exception and everything goes to 
hell?

{noformat}
[junit4]   2> 382495 ERROR (qtp1634550731-3340) [n:127.0.0.1:53893_solr 
c:backuprestore_testok    ] o.a.s.h.RequestHandlerBase 
java.security.AccessControlException: access denied ("java.io.FilePermission" 
"/location/does/not/exist" "read")
   [junit4]   2>        at 
java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
   [junit4]   2>        at 
java.base/java.security.AccessController.checkPermission(AccessController.java:1036)
   [junit4]   2>        at 
java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:408)
   [junit4]   2>        at 
java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:747)
   [junit4]   2>        at 
java.base/sun.nio.fs.UnixPath.checkRead(UnixPath.java:818)
   [junit4]   2>        at 
java.base/sun.nio.fs.UnixFileSystemProvider.exists(UnixFileSystemProvider.java:525)
   [junit4]   2>        at java.base/java.nio.file.Files.exists(Files.java:2513)
   [junit4]   2>        at 
org.apache.solr.core.backup.repository.LocalFileSystemRepository.exists(LocalFileSystemRepository.java:115)
   [junit4]   2>        at 
org.apache.solr.handler.admin.CollectionsHandler$CollectionOperation.lambda$static$33(CollectionsHandler.java:1109)
   [junit4]   2>        at 
org.apache.solr.handler.admin.CollectionsHandler$CollectionOperation.execute(CollectionsHandler.java:1325)
   [junit4]   2>        at 
org.apache.solr.handler.admin.CollectionsHandler.invokeAction(CollectionsHandler.java:265)
{noformat}

> TestLocalFSCloudBackupRestore may have exposed corruption possibility
> ---------------------------------------------------------------------
>
>                 Key: SOLR-14061
>                 URL: https://issues.apache.org/jira/browse/SOLR-14061
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: SOLR-14061.log
>
>
> This test really expects "/location/does/not/exist" to not exist. It seems to 
> pass (most of the time). But running on my computer under heavy load, it 
> fails with AlreadyClosedException from CachingDirectoryFactory, 
> NoSuchFileException from lucene for index files, threads and resources 
> leaking everywhere, it dies pretty violently.
> And I really don't like that I see NoSuchFileException for files in the 
> underlying lucene index files in the logs: this seems really bad: looks like 
> corruption to me.
> So I think some exceptions or errors (SecurityException in this case) might 
> be unexpected and cause something bad to happen. This could happen in 
> production with something like OutOfMemoryError or IOError that is rare but 
> currently handled incorrectly.
> I will open a separate issue to grant read access to 
> "/location/does/not/exist" so that the test works as designed, but I want to 
> file this one in case there is the chance that an unexpected Throwable of 
> some kind can cause corruption. I will upload logs and seeds and stuff.
> please close as won't fix if this is a false alarm, I didn't review the code, 
> I just read the damage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to