[
https://issues.apache.org/jira/browse/SOLR-14050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993775#comment-16993775
]
ASF subversion and git services commented on SOLR-14050:
--------------------------------------------------------
Commit dc031ea382d0a8531b447d8d9e1a8f1b385fdc08 in lucene-solr's branch
refs/heads/master from Robert Muir
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=dc031ea ]
SOLR-14050: clean up tests use of network addresses
Solr tests now have a similar policy to Lucene, loopback use only. If a
test tries to resolve or connect to the internet, it will get SecurityException.
Some solr tests explicitly try to talk to dead nodes with real
networking. This is not good and asking for trouble, but use low loopback port
numbers instead of
multicast addresses. The idea is that it fails faster. Move these to
constants so that stuff isn't copy-pasted everywhere, in case we have to
do something different later.
> clean up tests use of network addresses
> ---------------------------------------
>
> Key: SOLR-14050
> URL: https://issues.apache.org/jira/browse/SOLR-14050
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Robert Muir
> Priority: Major
> Attachments: SOLR-14050.patch
>
>
> Motivated by this tweet:
> https://twitter.com/ichattopadhyaya/status/1204274908454219778
> I think we should clean up the "connect/resolve anywhere" security
> permissions in the tests and make it stricter like lucene. This way we can
> prevent tests from doing slow things now or in the future.
> The biggest issue I see exploring this so far is solr has lots of tests that
> want to hit a "dead" node. If you get lucky test passes quickly. If you get
> unlucky (e.g. it tries to route that multicast ipv6 address somewhere?) then
> it passes slowly or maybe even times out or misbehaves.
> I think, depending on the networking environment (e.g. working ipv6 or not,
> maybe OS), the current way its being done can be terribly slow. I have some
> ideas, just need to do some testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
