[ 
https://issues.apache.org/jira/browse/SOLR-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16992934#comment-16992934
 ] 

Chris M. Hostetter commented on SOLR-14033:
-------------------------------------------

Cursory (linux) testing suggests that this fixes the bulk of the jenkins 
failures we've been seeing lately related to HDFS/Hadoop/DelegateToken testing.

it seems like we should probably also add:
* some dev docs (package level javadocs?) explaining the whole 
{{org.apache.hadoop}} "shadow" class impls
* ideally include some hook in {{HdfsTestUtil}} that causes it to fail fast if 
it can detect that the classloader didn't pick up our modified classes? .. 
maybe by adding a new {{public static final Object 
SOLR_HACK_FOR_CLASS_VERIFICATION = new Object}} to each 
{{org.apache.hadoop.\*\*}} that it could check for via reflection?

...but those (and discussion of those) could easily be defered to their own 
JIras.

+1 to commiting this ASAP (unless you know of some reason to wait that i don't 
see)

> Fix Hadoop tests with security manager
> --------------------------------------
>
>                 Key: SOLR-14033
>                 URL: https://issues.apache.org/jira/browse/SOLR-14033
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Hadoop Integration, hdfs, Tests
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>         Attachments: SOLR-14033.patch
>
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> SOLR-14000 and SOLR-14002 have been cleaning this up. Seeing some HDFS suite 
> failures due to missing nulling out static variables and Hadoop being stupid 
> with the security manager.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to