[jira] [Commented] (SOLR-13990) Switch out woodstox-core-asl with aalto-xml and upgrade woodstox stax-2 API

[Mike Drob (Jira)]

    [ 
https://issues.apache.org/jira/browse/SOLR-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990214#comment-16990214
 ] 

Mike Drob commented on SOLR-13990:
----------------------------------

Woodstox supports internal entity resolution (I have no opinions on this) and 
our custom entity resolver drops external entities (this is a big security 
issue and very important to do).

Looks like https://github.com/FasterXML/aalto-xml/issues/28 was closed out with 
the comment that Aalto will not support even internal entities, which is where 
it gets that 100% speedup from.

The failing test case in 
{{org.apache.solr.handler.dataimport.TestXPathEntityProcessor}} is because of 
the data
{code}
<?xml version=\"1.0\" encoding=\"UTF-8\"?>
<!DOCTYPE root [
  <!ENTITY uuml \"&#252;\" >
]>
<root><a>1</a><a>2</a><a>&uuml;</a></root>
{code}
so we're explicitly expecting entity resolution to work.

> Switch out woodstox-core-asl with aalto-xml and upgrade woodstox stax-2 API
> ---------------------------------------------------------------------------
>
>                 Key: SOLR-13990
>                 URL: https://issues.apache.org/jira/browse/SOLR-13990
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Switched out woodstox-core-asl with aalto-xml and upgrade woodstax stax-2 
> API. 
> About aalto-xml:
> Aalto XML processor is an ultra-high performance next generation Stax XML 
> processor implementation, implementing both basic Stax API 
> ({{javax.xml.stream}}) and Stax2 API extension 
> ({{org.codehaus.woodstox.stax2}}). In addition, it also implements SAX2 API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org