[ https://issues.apache.org/jira/browse/SOLR-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981181#comment-16981181 ]
David Eric Pugh commented on SOLR-13965: ---------------------------------------- I notice that GraphHandler and StreamHandler share a lot of code. And in fact, GraphHandler actually references {{StreamHandler.clientCache}} directly at https://github.com/apache/lucene-solr/blob/master/solr/core/src/java/org/apache/solr/handler/GraphHandler.java#L120. I wonder if removing the various classes attached to GraphHandler such as DummyErrorStream, TimerStream and using the ones from StreamHandler would make sense? > Adding new functions to GraphHandler should be same as Streamhandler > -------------------------------------------------------------------- > > Key: SOLR-13965 > URL: https://issues.apache.org/jira/browse/SOLR-13965 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: streaming expressions > Affects Versions: 8.3 > Reporter: David Eric Pugh > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Currently you add new functions to GraphHandler differently than you do in > StreamHandler. We should have one way of extending the handlers that support > streaming expressions. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org