[
https://issues.apache.org/jira/browse/SOLR-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-13952:
----------------------------------
Component/s: Build
Description:
The gradle_8 branch has many changes unrelated to gradle. It would be much
easier to work on the gradle parts if these were separated. So here's my plan:
This turned out not to be as hard as I expected. I'll create a sub-task for the
functional changes and use this one for the non-functional changes.
Non-functional changes are the overwhelming majority of changes. There are a
few categories of change here:
* SuppressWarnings, rawtypes, deprecated.
* SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter and
QuickPatchThreadsFilter. These are know thread leaks from third-party products
(IBM Java, and a Log4J2 thread was added)
* some static imports were removed
* some reformatting, given that this whole patch is not about functional
changes I decided to leave them in.
* Some very minor code changes:
** change "new Path(leaderPath).getParent().toString();" to
"Paths.get(leaderPath).getParent().toString();"
** mods like new HashMap(); <- new HashMap<>();
* Log messages added
was:
The gradle_8 branch has many changes unrelated to gradle. It would be much
easier to work on the gradle parts if these were separated. So here's my plan:
- establish a branch to use for the non-gradle parts of the gradle_8 branch and
commit separately. For a first cut, I'll make all the changes I'm confident of,
and mark the others with nocommits so we can iterate and decide when to merge
to master and 8x.
- create a "gradle_9" branch that hosts only the gradle changes for us all to
iterate on.
I hope to have a preliminary cut at this over the weekend.
> Separate out Gradle-specific code from other (mostly test) changes and commit
> separately
> ----------------------------------------------------------------------------------------
>
> Key: SOLR-13952
> URL: https://issues.apache.org/jira/browse/SOLR-13952
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: fordavid.patch
>
>
> The gradle_8 branch has many changes unrelated to gradle. It would be much
> easier to work on the gradle parts if these were separated. So here's my plan:
> This turned out not to be as hard as I expected. I'll create a sub-task for
> the functional changes and use this one for the non-functional changes.
> Non-functional changes are the overwhelming majority of changes. There are a
> few categories of change here:
> * SuppressWarnings, rawtypes, deprecated.
> * SuppressWarnings for known thread leaks by adding SolrIgnoreThreadsFilter
> and QuickPatchThreadsFilter. These are know thread leaks from third-party
> products (IBM Java, and a Log4J2 thread was added)
> * some static imports were removed
> * some reformatting, given that this whole patch is not about functional
> changes I decided to leave them in.
> * Some very minor code changes:
> ** change "new Path(leaderPath).getParent().toString();" to
> "Paths.get(leaderPath).getParent().toString();"
> ** mods like new HashMap(); <- new HashMap<>();
> * Log messages added
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
