[
https://issues.apache.org/jira/browse/LUCENE-9049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980643#comment-16980643
]
Robert Muir commented on LUCENE-9049:
-------------------------------------
Since removing the cache seems to work out here, I'm curious (can be separate
issue) if ~30k han cache in kuromoji is redundant after LUCENE-8920 changes
(https://github.com/apache/lucene-solr/blob/813ca77250db29116812bc949e2a466a70f969a3/lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoFST.java#L35-L38)
Actually the entire linked file's purpose is all around this caching, so if its
not needed anymore it would be a nice cleanup. But it was definitely needed for
good performance before, so we shoudl be careful. Nori analyzer has the exact
same thing (file has the same name) for ~10k hangul syllables.
> Remove FST cachedRootArcs now redundant with direct-addressing
> --------------------------------------------------------------
>
> Key: LUCENE-9049
> URL: https://issues.apache.org/jira/browse/LUCENE-9049
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Bruno Roustant
> Priority: Major
> Attachments: LUCENE-9049.patch
>
>
> With LUCENE-8920 FST most often encodes top level nodes with
> direct-addressing (instead of array for binary search). This probably made
> the cachedRootArcs redundant. So they should be removed, and this will reduce
> the code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
