[ 
https://issues.apache.org/jira/browse/LUCENE-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977643#comment-16977643
 ] 

Chris M. Hostetter commented on LUCENE-9040:
--------------------------------------------

right – and at a higher, more conceptual, level: even if you weren't trying to 
{{.equals()}} two IndexCommit objects, even if you were just trying to inspect 
some IndexCommits via the {{getGeneration()}} method would it really make sense 
that a "real" on disk commit can return the same numeric value as completely 
diff "view" of the index (that hasn't actually been committed yet) and has 
completlye diff data in it due to un-committed adds/deletes?

I guess my main concern is that even if these are really hard/confusing 
problems to solve with how the various APIs are designed for the "common case" 
we should probably beef up the docs to clarify when they might return 
meaningless results (or what limitations exist on that meaning, like "When 
using a reopend reader, the IndexCommit returned will identify the most 
recently committed generation, not the 'future' generation that will be used on 
the next commit, and all other IndexCommit metadata may be meaningless"

> Questionable/Underspecified behavior of DirectoryReader.getIndexCommit() on 
> NRT Readers
> ---------------------------------------------------------------------------------------
>
>                 Key: LUCENE-9040
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9040
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: LUCENE-9040.patch
>
>
> It seems like DirectoryReader.getIndexCommit() returns weird 
> results when using a "reopened" reader off of uncommited IW changes.
> Even though 2 diff readers will expose diff views of the index, they will 
> claim to refer to the same IndexCommit (generation).
> Original email thread (no replies): 
> http://mail-archives.apache.org/mod_mbox/lucene-dev/201910.mbox/%3Calpine.DEB.2.21.1910301611190.8171%40slate%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to