chatman commented on a change in pull request #994: SOLR-13662: Package Manager
(CLI)
URL: https://github.com/apache/lucene-solr/pull/994#discussion_r346092779
##########
File path:
solr/core/src/test-files/solr/question-answer-repository/repository.json
##########
@@ -0,0 +1,57 @@
+[
+ {
+ "name": "question-answer",
+ "description": "A natural language question answering plugin",
+ "versions": [
+ {
+ "version": "1.0.0",
+ "date": "2019-01-01",
+ "artifacts": [
+ {
+ "url": "question-answer-request-handler-1.0.jar",
+ "sig":
"C9UWKkucmY3UNzqn0VLneVMe9kCbJjw7Urc76vGenoRwp32xvNn5ZIGZ7G34xZP7cVjqn/ltDlLWBZ/C3eAtuw=="
+ }
+ ],
+ "manifest": {
+ "min-solr-version": "8.0",
+ "max-solr-version": "9.99",
+ "plugins": [
+ {
+ "name": "request-handler",
+ "setup-command": {
+ "path": "/api/collections/${collection}/config",
Review comment:
Package manager (CLI) needs write access to ZK for "add-repo", since it
needs to publish the trusted public key. A user must only "add-repo" for a
trusted publisher. Only then should the user expect non-malicious packages.
Once a package is already in the system, it doesn't matter if the deploy
step (which is a CLI action) executes a HTTP command or does something
malicious from inside the jar file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
