jpountz commented on a change in pull request #973: LUCENE-9027: Use SIMD
instructions to decode postings.
URL: https://github.com/apache/lucene-solr/pull/973#discussion_r345847390
##########
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBufferIndexInput.java
##########
@@ -107,6 +122,24 @@ public final void readBytes(byte[] b, int offset, int
len) throws IOException {
}
}
+ @Override
+ public void readLongs(ByteOrder byteOrder, long[] dst, int offset, int
length) throws IOException {
+ try {
+ final int position = curBuf.position();
+ guard.getLongs(curLongBufferViews[position & 0x07].position(position >>>
3), dst, offset, length);
Review comment:
For the record, there are 8, not 63 clones. Currently blocks all take
`bitsPerValue * 16 + 1` bytes, so adding padding would waste 7 bytes all the
time. This would be a 42% increase for 1 bpv blocks and 21% for 2 bpv, which
are not that uncommon bits per value for term freqs, especially when exceptions
help lower the number of bits per value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
