tflobbe commented on a change in pull request #984: SOLR-12217: Support shards.preference for individual shard requests URL: https://github.com/apache/lucene-solr/pull/984#discussion_r340880125
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java ########## @@ -1109,11 +1125,12 @@ public RouteException(ErrorCode errorCode, NamedList<Throwable> throwables, Map< } } - // Shuffle the leaders, if any (none if !sendToLeaders) + // Sort the leader replicas, if any, according to the request preferences (none if !sendToLeaders) + replicaListTransformer.transform(replicas); Review comment: `theUrlList`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org