[
https://issues.apache.org/jira/browse/SOLR-13858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959126#comment-16959126
]
Andrzej Bialecki commented on SOLR-13858:
-----------------------------------------
Initial patch. It's quite sizeable because of the API change - actual changes
in implementing classes are minimal.
I decided to move the registration of metric names to {{SolrMetricsContext}}
and be more consistent about creating child contexts for individual components.
Still, it's possible that some of the MBean information presented in UI and in
JMX may have changed.
> Clean up SolrInfoBean / SolrMetricProducer API
> ----------------------------------------------
>
> Key: SOLR-13858
> URL: https://issues.apache.org/jira/browse/SOLR-13858
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Fix For: master (9.0)
>
> Attachments: SOLR-13858.patch
>
>
> For historical reasons both {{SolrInfoBean}} and {{SolrMetricProducer}}
> contain methods and constants / enums that deal with handling and reporting
> of metrics. In almost all cases implementations of {{SolrInfoBean}} also
> implement {{SolrMetricProducer}}.
> I propose to refactor this API so that {{SolrInfoBean}} simply extends
> {{SolrMetricProducer}}. This will reduce the API surface and eliminate
> multiple rote methods that subclasses must now implement.
> This is an incompatible API change so it's applicable only to version 9.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
