atris commented on issue #923: LUCENE-8988: Introduce Global Feature Based Early Termination For Sorted Fields URL: https://github.com/apache/lucene-solr/pull/923#issuecomment-541553077 > I think we should consider any global check as costly. That is true > Currently it is checked on every call after the first assignment and we're maybe checking the same values twice because the global one may be equal to the local one. Yeah. One thought that I have is if we should get rid of the local check completely since local minimum will be calibrated against the global minimum right before the early termination checks are done -- so we can never end up with local minimum being better than the global minimum. >We're introducing an interval between each global min score check in #, if we think it is useful to also check the values we can try the same approach here. Sure, we can explore that. > If we control the rate of the check that we need to perform on the shared bottom we can try to incorporate the values in our local pq rather than extracting the values of all document ? I am not sure I completely understand this part -- do you mean the shared PQ approach? > I also wonder what kind of impact do you expect with this change. While checking the minimum score globally can make a big difference I am not sure that the same holds for field values. We cannot efficiently skip blocks of documents and we have to perform an additional comparison on raw values so I would be curious to see benchmarks with this change. The minimum score is only applicable for indices that are sorted by relevance, whereas this change enables early terminating segments that are non competitive for all sort keys (irrespective of whether they are sorted by relevance or not) ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
