[ https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948645#comment-16948645 ]
Gézapeti edited comment on SOLR-13833 at 10/11/19 2:48 PM: ----------------------------------------------------------- I've tried to check the code and it looks like the DistributedUpdateProcessor changed. Based on code comments in DistributedUpdateProcessor: {noformat} // internal helper method to setup request by processors who use this class. // NOTE: not called by this class! void setupRequest(UpdateCommand cmd) { {noformat} setupRequest is called 3 times in DistributedUpdateProcessor: in processAdd, doDeleteById and doDeleteByQuery. It is also called in processAdd and processAdd and doDeleteById in DistributedZkUpdateProcessor. I'll try to untangle things. was (Author: gezapeti): It looks like the setRequest call is not needed in processAdd or doDeleteById for the checkReplicationTracker() to complete correctly. > setupRequest normally called twice > ---------------------------------- > > Key: SOLR-13833 > URL: https://issues.apache.org/jira/browse/SOLR-13833 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Yonik Seeley > Priority: Major > > I think this was introduced in SOLR-12955, but setupRequest is called > twice... > for example a single "add" causes it to be called once in > DistributedZkUpdateProcessor.processAdd() and then again in > DistributedUpdateProcessor.processAdd() -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org