janhoy opened a new pull request #938: SOLR-13665: Added missing netty dependencies to solrJ URL: https://github.com/apache/lucene-solr/pull/938 # Description ClassNotFound error when attempting SSL connection with the new Zookeeper 3.5.5. # Solution Added missing netty dependencies to solrJ and upgraded netty to v 4.1.29.Final which is the version ZK uses. See also https://issues.apache.org/jira/browse/ZOOKEEPER-3494. Probably the new Solr gradle build will "just work" from ZK 3.5.6 and later (for 3.5.5 we'd pull in netty-all which is unnecessarily large). # Tests Hard to test since we do not have any ZK SSL tests in the code base # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [ ] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
