KoenDG opened a new pull request #919: LUCENE-8994: Code Cleanup - Pass values to list constructor instead of empty constructor followed by addAll(). URL: https://github.com/apache/lucene-solr/pull/919 https://issues.apache.org/jira/projects/LUCENE/issues/LUCENE-8994 If you have actual serious issues to attend, no need to bother with this PR, it is code cleanup, not features or fixes. A small and unimportant PR. Some code cleanup. And perhaps in some cases a small performance gain. I would understand if issue was taken concerning readability in some cases. I could change those cases to look something like this, if it made if more readable: ``` new ArrayList<>( nameOfCollection.getMethod(someExtraVars) ); ``` Frankly, it already was equally unreadable in such cases as: ``` resources.addAll(Accountables.namedAccountables("field", fields)); ``` Depends on what the reviewer wants, I suppose.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
