thomaswoeckinger commented on a change in pull request #902: SOLR-13795: Reload solr core after schema is persisted. URL: https://github.com/apache/lucene-solr/pull/902#discussion_r330756503
########## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ########## @@ -138,7 +138,7 @@ protected List<SchemaField> fieldsWithDefaultValue = new ArrayList<>(); protected Collection<SchemaField> requiredFields = new HashSet<>(); - protected volatile DynamicField[] dynamicFields; Review comment: > @sarowe why was this volatile? It's fishy to see this as the only volatile field. I was looking for any double check pattern, or lazy init, found nothing, as you mentioned it is the only one, so i removed it, makes no sense from my point of view ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
