dsmiley commented on a change in pull request #911: SOLR-13802: Write analyzer
property luceneMatchVersion to managed schema
URL: https://github.com/apache/lucene-solr/pull/911#discussion_r329876510
##########
File path:
solr/core/src/test/org/apache/solr/rest/schema/TestBulkSchemaAPI.java
##########
@@ -125,7 +126,7 @@ public void testAnalyzerClass() throws Exception {
" 'name' : 'myNewTextFieldWithAnalyzerClass',\n" +
" 'class':'solr.TextField',\n" +
" 'analyzer' : {\n" +
- " 'luceneMatchVersion':'5.0.0',\n" +
+ " '" + IndexSchema.LUCENE_MATCH_VERSION_PARAM + "':'5.0.0',\n" +
Review comment:
Using Constants in tests like here is a bit too far IMO. It slightly
obscures readability and there's a point to be made that changing the
input/output constant _should_ break a test. Subjective, I know. I don't
mean to suggest the removal of all constants in tests but here in particular
it's ugly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
