mikemccand commented on a change in pull request #815: LUCENE-8213: Introduce
Asynchronous Caching in LRUQueryCache
URL: https://github.com/apache/lucene-solr/pull/815#discussion_r328207416
##########
File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java
##########
@@ -732,8 +779,29 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) throws IOExcepti
if (docIdSet == null) {
if (policy.shouldCache(in.getQuery())) {
- docIdSet = cache(context);
- putIfAbsent(in.getQuery(), docIdSet, cacheHelper);
+ boolean performSynchronousCaching = !(executor != null);
+
+ // If asynchronous caching is requested, perform the same and return
+ // the uncached iterator
+ if (!performSynchronousCaching) {
+ try {
+ cacheAsynchronously(context, cacheHelper);
+ } catch (RejectedExecutionException e) {
+ // Trigger synchronous caching
+ performSynchronousCaching = true;
+ }
+
+ // If async caching failed, synchronous caching will
+ // be performed, hence do not return the uncached value
+ if (!performSynchronousCaching) {
Review comment:
Change to `performSynchronousCaching == false`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
