[
https://issues.apache.org/jira/browse/SOLR-13775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933713#comment-16933713
]
ASF subversion and git services commented on SOLR-13775:
--------------------------------------------------------
Commit 27f7875d2d188f32ab46d93c98fd2f9e1624dd9a in lucene-solr's branch
refs/heads/master from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=27f7875 ]
SOLR-13775: Add note about permissions to "PR Template" (#891)
By default, when a Solr contributor creates their own fork, only they
have access to that fork. This creates a bit of a roadblock when users
contribute PRs from these forks - others can't build off of their work -
something that is done often with patches. An initial user might
contribute a feature, a committer might add tests or change formatting,
etc.
This commit introduces a bullet point to our PR checklist to nudge users
towards making their PR branches more open so that it's easier for committers
to help them.
> Update PR template to suggest Githubs: "Allow Edits From Maintainers" option
> ----------------------------------------------------------------------------
>
> Key: SOLR-13775
> URL: https://issues.apache.org/jira/browse/SOLR-13775
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: github
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As discussed recently on the mailing list, Github does have one big downside:
> it's pretty onerous for two people to both contribute code to the same PR.
> PR's typically come from personal-fork's of Solr, owned by an individual. If
> that individual doesn't think to give other collaborators edit-access, then
> they must open secondary-PRs to get their changes the primary PR. These
> secondary PRs must be reviewed, merged etc.
> This makes collaboration much more difficult than it is in the patch world
> for example, where I can (e.g.) help a contributor clean up their formatting
> by just uploading a new patch.
> Unfortunately the best workaround at this point for this in github is to
> prompt those opening PRs to grant access to Solr's upstream committers and
> maintainers. We can do this by linking users to this
> [option|https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork]
> in the "PR checklist" that was added recently.
> Users don't have to provide this access if they don't want. But hopefully
> it'll many collaboration easier in many cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
