jgq2008303393 commented on issue #884: LUCENE-8980: optimise SegmentTermsEnum.seekExact performance URL: https://github.com/apache/lucene-solr/pull/884#issuecomment-533150625 Thanks a lot, @dsmiley. I read the code you have shared. The design ideas between `uniformsplit.BlockReader` and this PR are similar. `uniformsplit.BlockReader` cuts off segments by the result of `BlockReader.seekBlock()`, while this PR cuts off segments directly according to the stored min/maxTerm metrics. We use Elasticsearch to support many time-series scenarios such as logs, APM, Metric, etc. And users typically add data using sequential IDs to ensure data uniqueness. As you said, this PR would be very noticeable in those scenarios since most segments will be cutted off directly. We will use _luceneutil_ to supply more performance test results according to your suggestions. Thanks again.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
